-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kargs: Introduce usage of fs_utf8 #676
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm going to redo this on top of coreos/cap-std-ext#53 once it's released |
This avoids annoyances with constantly checking for utf-8. Also the new `filenames_filtered_sorted` API we added to cap-std-ext is more concise and efficient. Signed-off-by: Colin Walters <[email protected]>
Done ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…json-1.0.119 build(deps): bump serde_json from 1.0.117 to 1.0.119
This avoids annoyances with constantly checking for utf-8.