install: Warn if we're not installing to gpt #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This correctly shows up in the aarch64 integration test because of osbuild/bootc-image-builder#551
|
I am not aware of any reason to use anything else; in theory we can leave this up to the OS, but...I think using `dos` format is really probably just a legacy mistake now. And if we see anything else...well, let's at least warn. Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
warn-install-non-gpt
branch
from
f1bc0b1
to
71d3435
Compare
|
Rebased 🏄 |
cgwalters
pushed a commit
to cgwalters/bootc
that referenced
this pull request
Nov 5, 2024
…json-1.0.127 build(deps): bump serde_json from 1.0.122 to 1.0.127
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not aware of any reason to use anything else; in theory we can leave this up to the OS, but...I think using
dosformat is really probably just a legacy mistake now.And if we see anything else...well, let's at least warn.