utils: Add a little CommandRunExt helper trait #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I added the `Task` stuff it wasn't with the idea that we'd use it for *all* subprocess invocations. I think in some cases we really just do want a `Command` instance without the extra wrappering. Add an implementation (there are many of variants of this out there in lots of Rust codebases) This makes sense to use instead of `Task` where we're using `.quiet()` so that we don't print the description, and especially where we don't expect the task to fail usually, so it's OK if the error message is odd. Signed-off-by: Colin Walters <[email protected]>
jmarrero
reviewed
Jul 26, 2024
| fn run(&mut self) -> Result<()>; | ||
| } | ||
|
|
||
| impl CommandRunExt for Command { |
There was a problem hiding this comment.
I see you are using Command::new and not CommandRunExt above. I am not sure I follow how this gets wired. I imagine that now everytime someone uses Command::new it will use this instead, but have no idea how that is happening.
There was a problem hiding this comment.
mmm I guess it's using trait and then the impl that wires this.
There was a problem hiding this comment.
Right, the trait adds a new method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I added the
Taskstuff it wasn't with the idea that we'd use it for all subprocess invocations.I think in some cases we really just do want a
Commandinstance without the extra wrappering.Add an implementation (there are many of variants of this out there in lots of Rust codebases)
This makes sense to use instead of
Taskwhere we're using.quiet()so that we don't print the description, and especially where we don't expect the task to fail usually, so it's OK if the error message is odd.