A few prep commits for https://github.com/containers/bootc/pull/724 #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
force-pushed
the
init-container-storage-prep3
branch
from
218ed0e
to
e944b5c
Compare
|
Blah, current rhel9 just has 1.75. I guess we should cap to that for now... |
cgwalters
force-pushed
the
init-container-storage-prep3
branch
from
e944b5c
to
badca4d
Compare
It's what's in c9s right now, and I want to make use of a newer API. Signed-off-by: Colin Walters <[email protected]>
I have a use case for dynamic strings, this just requires duplicating the string for the progress bar. Signed-off-by: Colin Walters <[email protected]>
Will be used by future changes. Signed-off-by: Colin Walters <[email protected]>
Prep for more work. Signed-off-by: Colin Walters <[email protected]>
We want to capture stderr by default in these methods so we provide useful errors. Also add an async variant. Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
init-container-storage-prep3
branch
from
badca4d
to
81556a4
Compare
cgwalters
pushed a commit
to cgwalters/bootc
that referenced
this pull request
Nov 5, 2024
….5.19 build(deps): bump clap from 4.5.18 to 4.5.19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
utils: Allow non-static str for spinner
I have a use case for dynamic strings, this just requires
duplicating the string for the progress bar.
Signed-off-by: Colin Walters [email protected]
lib: Enable mount API for rustix
Will be used by future changes.
Signed-off-by: Colin Walters [email protected]
tests: Add generic post-install verification
Prep for more work.
Signed-off-by: Colin Walters [email protected]
utils: Capture stderr, add async
We want to capture stderr by default in these methods
so we provide useful errors.
Also add an async variant.
Signed-off-by: Colin Walters [email protected]