A few misc cleanups #746
Merged
A few misc cleanups #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have no use for listing all devices, so drop it. Signed-off-by: Colin Walters <[email protected]>
We only have a case for listing one device. Signed-off-by: Colin Walters <[email protected]>
Prep for more stuff there. Signed-off-by: Colin Walters <[email protected]>
It's handy to have a central helper for this. Signed-off-by: Colin Walters <[email protected]>
It's shorter and clearer and we get stderr. Signed-off-by: Colin Walters <[email protected]>
I never intended the `Task` abstraction to be "the one way to run subprocesses in bootc"...let's stop using it where: - We're using `.quiet()` by default so we're not printing the description anyways, which is the *main* thing Task does - We want to parse JSON, where we have a nice new helper Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
block-cmd-cleanup
branch
from
64a5f68
to
89aacb7
Compare
Signed-off-by: Colin Walters <[email protected]>
|
failure on x86_64: I think that is likely a flake as it passed on aarch64... |
|
Yep #579 is tracking that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blockdev: Drop dead code
We have no use for listing all devices, so drop it.
Signed-off-by: Colin Walters [email protected]
blockdev: Fold listing fn
We only have a case for listing one device.
Signed-off-by: Colin Walters [email protected]
lib: Move Command extensions to new
mod cmdutilPrep for more stuff there.
Signed-off-by: Colin Walters [email protected]
cmdutils: Add helper to run and parse JSON
It's handy to have a central helper for this.
Signed-off-by: Colin Walters [email protected]
blockdev: Use JSON parsing helper
It's shorter and clearer and we get stderr.
Signed-off-by: Colin Walters [email protected]
Switch a few Task users to direct Command
I never intended the
Taskabstraction to be "the one way torun subprocesses in bootc"...let's stop using it where:
.quiet()by default so we're not printing thedescription anyways, which is the main thing Task does
Signed-off-by: Colin Walters [email protected]
Fix two minor clippy lints
Signed-off-by: Colin Walters [email protected]