tests: Add tmt test for bootc install with LBI #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
approved these changes
Sep 18, 2024
xtask/src/xtask.rs
Outdated
| // pull some small images that are used for LBI installation tests | ||
| cmd!( | ||
| sh, | ||
| "podman pull quay.io/curl/curl-base:latest quay.io/curl/curl:latest" |
There was a problem hiding this comment.
Minor: probably worth factoring out a const TEST_IMAGES: &[&str] = ... at the top of the file for increased visibility?
This one actually also relates to https://gitlab.com/fedora/bootc/examples/-/merge_requests/50#note_2041291332
which hmmm, I need to finish that PR
| @@ -0,0 +1,3 @@ | |||
| [Image] | |||
| Image=registry.redhat.io/jboss-webserver-5/jws5-rhel8-operator:latest | |||
| AuthFile=/root/auth.json | |||
There was a problem hiding this comment.
nope, added a comment to explain that it's meant to represent a quadlet image that is not logically bound.
ckyrouac
force-pushed
the
lbi-install-tmt
branch
from
c74f64d
to
6ccf4c8
Compare
|
This just needs a |
Along with the test, this will install the LBIs on the machine running the tests prior to running the tests. Also refactors the existing LBI test into a separate test plan to make room for the install tests. Signed-off-by: Chris Kyrouac <[email protected]>
ckyrouac
force-pushed
the
lbi-install-tmt
branch
from
6ccf4c8
to
0f09ae2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along with the test, this will install the LBIs on the machine running the tests prior to running the tests. Also refactors the existing LBI test into a separate test plan to make room for the install tests.