Skip to content

Name extendedGlob() anonymous functions #6265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Name extendedGlob() anonymous functions #6265

wants to merge 1 commit into from

Conversation

sebsoto
Copy link

@sebsoto sebsoto commented Jul 3, 2025 •
edited by TomSweeneyRedHat
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Moves inline function definitions out of the extendedGlob() function.
Helps with code readability.

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 3, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sebsoto
Once this PR has been reviewed and has the lgtm label, please assign baude for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

TomSweeneyRedHat
TomSweeneyRedHat reviewed Jul 9, 2025
View reviewed changes
copier/copier.go Outdated
return patterns
}

// subDirs returns a recursive search of all directories under the given dir
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style comment only, not necessary to change. I'd rather see this function precede expandPatterns as expandPatterns calls it.

@TomSweeneyRedHat TomSweeneyRedHat added the No New Tests Allow PR to proceed without adding regression tests label Jul 9, 2025
@TomSweeneyRedHat
Copy link
Member

LGTM

@TomSweeneyRedHat
Copy link
Member

@sebsoto can you rebase this? You haven't encountered it yet, but I think #6271 will resolve the test issues you would otherwise face.

@sebsoto
Name extendedGlob() anonymous functions
a3dcd82 
Moves inline function definitions out of the function.
Helps with code readability.

Signed-off-by: Sebastian Soto <[email protected]>
@sebsoto
Copy link
Author

sebsoto commented Jul 9, 2025

@TomSweeneyRedHat Rebased. Also swapped the functions as requested.

@TomSweeneyRedHat
Copy link
Member

LGTM
🤞 for happy tests

@TomSweeneyRedHat
Copy link
Member

Well, that's new to me. The Smoke Test failed because it was unable to pull an Alpine image. I didn't think it actually pulled an Alpine image, but I guess it does. Anyway, I've restarted the tests, and it seems to be progressing now.

@github-actions GitHub Actions
Copy link

A friendly reminder that this PR had no activity for 30 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomSweeneyRedHat TomSweeneyRedHat TomSweeneyRedHat left review comments

Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. No New Tests Allow PR to proceed without adding regression tests stale-pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebsoto @TomSweeneyRedHat