fix(build): make --tag oci-archive:xxx.tar work with simple images

[aeijdenberg]

What type of PR is this?

/kind bug

What this PR does / why we need it:

This allows buildah build -f <(echo 'FROM busybox') --tag=oci-archive:out.tar to succeed without error.

How to verify it

bats test added.

Which issue(s) this PR fixes:

FIxes #6280

Special notes for your reviewer:

It's not 100% clear to me this is the right solution to fix, but I noticed that other code which adds tags to images, such as

buildah/imagebuildah/executor.go

Lines 1054 to 1057 in 8403fd6

	// Add additional tags and print image names recorded in storage
	if dest, err := b.resolveNameToImageRef(b.output); err == nil {
	switch dest.Transport().Name() {
	case storageTransport.Transport.Name():

does the same check before trying to tag, so this duplicates that check and adds it to this other code path.

Does this PR introduce a user-facing change?

None

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aeijdenberg
Once this PR has been reviewed and has the lgtm label, please assign nalind for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nalind]

Thanks! Though this bypasses the cp.Image() call further down, which is what would write the output image, and I think we want to keep writing the image.

[aeijdenberg]

Thanks! Though this bypasses the cp.Image() call further down, which is what would write the output image, and I think we want to keep writing the image.

You're right, and we certainly do want to keep writing the image out. I'm pretty sure I had that working in an earlier iteration - I'll see what I missed, fix up and add more tests.

Thanks for the pickup...

[aeijdenberg]

Rebased and included the additional fix originally submitted in #6298

[github-actions]

A friendly reminder that this PR had no activity for 30 days.

[dustymabe]

I think this helped me get around an error I was seeing. @nalind - mind another review?