Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR 2202 #2227

Closed
wants to merge 5 commits into from
Closed

Revert PR 2202 #2227

wants to merge 5 commits into from

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Nov 4, 2024

We suspect this is causing issue sin podman as multi arch builds are no longer working as the pulling in parallel seems to break

# Error: [linux/s390x]: creating build container: looking up a just-pulled image: reference "[vfs@/var/tmp/buildah_tests.6dq4pu/root+/var/tmp/buildah_tests.6dq4pu/runroot]docker.io/library/alpine@sha256:43955d6857268cc948ae9b370b221091057de83c4962da0826f9a2bdc9bd6b44" does not resolve to an image ID: identifier is not an image

containers/podman#24447

Draft until we now we will not fix it in time for the 5.3 release and I confirmed this fixes the podman regression

This reverts commit aa722ef.

Signed-off-by: Paul Holzinger <[email protected]>
…istry"

This reverts commit be7818a.

Signed-off-by: Paul Holzinger <[email protected]>
This reverts commit a376d89.

Signed-off-by: Paul Holzinger <[email protected]>
This reverts commit 3339ddc.

Signed-off-by: Paul Holzinger <[email protected]>
This reverts commit e2324dd.

Signed-off-by: Paul Holzinger <[email protected]>
Copy link
Contributor

openshift-ci bot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 4, 2024
Luap99 added a commit to Luap99/libpod that referenced this pull request Nov 4, 2024
@mtrmac
Copy link
Contributor

mtrmac commented Nov 4, 2024

Alternatively, consider merging containers/image#2609 + #2209 . I’d prefer that. Test running in containers/podman#24462 .

Or, reverting only aa722ef should be sufficient per my manual testing (but reverting the whole PR as a unit is, of course, entirely fair.)

Luap99 added a commit to Luap99/libpod that referenced this pull request Nov 5, 2024
@Luap99 Luap99 closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants