Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cgroup: fix error return value #1258

Merged
merged 1 commit into from
Aug 6, 2023

Conversation

eriksjolund
Copy link
Contributor

It looks the number -1 should be something else so that it can be avoided that
crun_make_error() returns 0. Is that a correct analysis?

I don't know which number would be a good replacement.

Signed-off-by: Erik Sjölund <[email protected]>
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan rhatdan marked this pull request as ready for review August 5, 2023 09:50
@giuseppe giuseppe merged commit a6e2f2e into containers:main Aug 6, 2023
35 checks passed
@eriksjolund eriksjolund deleted the fix_error_return_value branch August 14, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants