linux: simplify setns with pidfd #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test failure is related |
This caused an issue when the PID 1 didn't execve yet the container process, and joining the user namespace first would cause the user to look access to the container PID 1 namespaces. When running with enough permissions, setns() will allow to join all the namespaces in one shoot, so let's use it. On any error, attempt the fallback mechanism to join each namespace separately. Closes: containers#1264 Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
simplify-setns-with-pidfd
branch
from
ea1ba0d
to
88441d9
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused an issue when the PID 1 didn't execve yet the container process, and joining the user namespace first would cause the user to look access to the container PID 1 namespaces.
When running with enough permissions, setns() will allow to join all the namespaces in one shoot, so let's use it.
On any error, attempt the fallback mechanism to join each namespace separately.
Closes: #1264