Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container: fix error return value #1267

Merged

Conversation

eriksjolund
Copy link
Contributor

No description provided.

@eriksjolund eriksjolund force-pushed the container_fix_error_return_value branch from 3abb5f6 to cf72f8b Compare August 8, 2023 18:34
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuseppe giuseppe merged commit 4cd102e into containers:main Aug 9, 2023
34 checks passed
@terinjokes
Copy link
Contributor

For my future reference, when should I have used crun_make_error versus crun_error_wrap like other return locations?

@giuseppe
Copy link
Member

giuseppe commented Aug 9, 2023

crun_error_wrap is to add more context to an existing error, while crun_make_error is to create a new error (possibly starting from an errno value)

@terinjokes
Copy link
Contributor

Thanks. I understand (and can see that pattern) in the other usages now.

@eriksjolund eriksjolund deleted the container_fix_error_return_value branch August 14, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants