Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPM/Packit: Fix wasm conditionals, cleanup rpm spec, update packit config #1533

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Aug 28, 2024

  1. Wrongly mentioned conditionals were causing crun-wasm package
    creation on CentOS Stream 10 and ELN environments which don't have
    wasm support yet.

  2. All environments that end up consuming rpm/crun.spec have rpmautospec
    enabled so we don't need these conditionals anymore. CentOS Stream 9
    should soon get rpmautospec support as well, and the current lack of it
    is not really a blocker to removal of these conditionals.

  3. Simplify TMT tests

Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@lsm5 lsm5 changed the title RPM: do not create crun-wasm symlink Packit: Enable podman-next repo to fetch wasmedge Aug 28, 2024
Copy link

podman system tests failed. @containers/packit-build please check.

@rhatdan
Copy link
Member

rhatdan commented Aug 28, 2024

LGTM

Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

Copy link

podman system tests failed. @containers/packit-build please check.

Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

Copy link

podman system tests failed. @containers/packit-build please check.

Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

Copy link

podman system tests failed. @containers/packit-build please check.

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

should we merge this or wait all the CI tests are green?

@lsm5
Copy link
Member Author

lsm5 commented Sep 2, 2024

LGTM

should we merge this or wait all the CI tests are green?

let's wait until test jobs are green.

@lsm5 lsm5 force-pushed the rpm-wasm-symlink branch 5 times, most recently from 464e4b8 to 03a827f Compare September 2, 2024 15:36
@lsm5
Copy link
Member Author

lsm5 commented Sep 3, 2024

/packit test packit/containers-common#2145

@lsm5
Copy link
Member Author

lsm5 commented Sep 3, 2024

/packit test containers/common#2145

1 similar comment
@lsm5
Copy link
Member Author

lsm5 commented Sep 3, 2024

/packit test containers/common#2145

@lsm5
Copy link
Member Author

lsm5 commented Sep 4, 2024

/packit test containers/common#2145

@lsm5
Copy link
Member Author

lsm5 commented Sep 5, 2024

/packit test containers/common#2145

Signed-off-by: Giuseppe Scrivano <[email protected]>
@lsm5
Copy link
Member Author

lsm5 commented Sep 5, 2024

/packit test containers/common#2145

@lsm5 lsm5 force-pushed the rpm-wasm-symlink branch 2 times, most recently from c775b3e to 4e8755c Compare September 5, 2024 11:05
@lsm5
Copy link
Member Author

lsm5 commented Sep 5, 2024

/packit test containers/common#2145

@lsm5
Copy link
Member Author

lsm5 commented Sep 5, 2024

/packit test containers/common#2145

…nfig

1. Wrongly mentioned conditionals were causing crun-wasm package
   creation on CentOS Stream 10 and ELN environments which don't have
   wasm support yet.

2. All environments that end up consuming rpm/crun.spec have rpmautospec
   enabled so we don't need these conditionals anymore. CentOS Stream 9
   should soon get rpmautospec support as well, and the current lack of it
   is not really a blocker to removal of these conditionals.

3. Simplify TMT tests

Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5 lsm5 marked this pull request as ready for review September 5, 2024 13:58
@lsm5
Copy link
Member Author

lsm5 commented Sep 5, 2024

@giuseppe PTAL

@lsm5 lsm5 changed the title Packit: Enable podman-next repo to fetch wasmedge RPM/Packit: Fix wasm conditionals, cleanup rpm spec, update packit config Sep 5, 2024
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

green CI yey!

LGTM

@giuseppe giuseppe merged commit 00fde03 into containers:main Sep 5, 2024
56 checks passed
@lsm5 lsm5 deleted the rpm-wasm-symlink branch September 6, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants