fix getpwuid_r error handling #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getpwuid_r returns the error directly, not -1. In a situation with no /etc/passwd for example, ret is ENOFILE (2) and so the branch is never taken, resulting in a runaway realloc loop Signed-off-by: Andrew Consroe <[email protected]>
|
Ephemeral COPR build failed. @containers/packit-build please check. |
|
podman system tests failed. @containers/packit-build please check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getpwuid_r returns the error directly, not -1. In a situation with no /etc/passwd for example, ret is ENOFILE (2) and so the branch is never taken, resulting in a runaway realloc loop
Closes: #1536