Report executable not found errors after tty has been setup

[saschagrunert]

This allows to pass the error (as others) through the tty and not lose it.

Fixes #1524

[packit-as-a-service]

Ephemeral COPR build failed. @containers/packit-build please check.

[packit-as-a-service]

podman system tests failed. @containers/packit-build please check.

[kwilczynski]

@saschagrunert, this is because of the ordering? Because of this code block?

crun/src/libcrun/container.c

Lines 1269 to 1294 in c5c6679

	if (has_terminal)
	{
	cleanup_close int terminal_fd = -1;
	fflush (stderr);
	terminal_fd = libcrun_set_terminal (container, err);
	if (UNLIKELY (terminal_fd < 0))
	return terminal_fd;
	if (console_socket >= 0)
	{
	ret = send_fd_to_socket (console_socket, terminal_fd, err);
	if (UNLIKELY (ret < 0))
	return ret;
	close_and_reset (&console_socket);
	}
	else if (entrypoint_args->has_terminal_socket_pair && console_socketpair >= 0)
	{
	ret = send_fd_to_socket (console_socketpair, terminal_fd, err);
	if (UNLIKELY (ret < 0))
	return ret;
	close_and_reset (&console_socketpair);
	}
	}

The description is unclear as to how this issue is being fixed.

[saschagrunert]

@saschagrunert, this is because of the ordering? Because of this code block?

Yes, in theory we could also remove the pre-check of the command availability but I thought the whole block was intentionally added so I kept it.

[giuseppe]

LGTM

[saschagrunert]

The codespell is fixed in #1547

[rhatdan]

LGTM

[packit-as-a-service]

Ephemeral COPR build failed. @containers/packit-build please check.