Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: fix PATH lookup #1665

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Conversation

eriksjolund
Copy link
Contributor

Support filenames starting with a dot when
doing PATH lookup.

Fixes: #1664

Support filenames starting with a dot when
doing PATH lookup.

Fixes: containers#1664

Signed-off-by: Erik Sjölund <[email protected]>
@eriksjolund
Copy link
Contributor Author

eriksjolund commented Feb 10, 2025

I just did a quick fix. Is the fix this easy?


I did a test with crun built from this PR:

$ podman --runtime ~/bin/crun run --rm myimg ...test
hello

It worked.

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuseppe giuseppe merged commit 0c9ff87 into containers:main Feb 11, 2025
48 checks passed
@eriksjolund eriksjolund deleted the fix-PATH-lookup branch February 12, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

runc succeeds but crun fails with Error: crun: executable file ...test not found in $PATH
2 participants