Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main: fix performance issue with large dirs #402

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

giuseppe
Copy link
Member

cache the number of links for a directory instead of calculating it on every stat. It makes a huge difference when the directory has a lot of entries.

Closes: #401

Signed-off-by: Giuseppe Scrivano [email protected]

cache the number of links for a directory instead of calculating it on
every stat.  It makes a huge difference when the directory has a lot
of entries.

Closes: containers#401

Signed-off-by: Giuseppe Scrivano <[email protected]>
Signed-off-by: Giuseppe Scrivano <[email protected]>
@giuseppe
Copy link
Member Author

@flouthoc PTAL

Copy link
Contributor

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuseppe
Copy link
Member Author

thanks for the review

@giuseppe giuseppe merged commit ff6b14d into containers:main Aug 29, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

overlay driver is very slow in podman-in-podman builds with large COPY layer
2 participants