Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run unit tests on linux #457

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Run unit tests on linux #457

merged 2 commits into from
Jan 13, 2025

Conversation

lstocchi
Copy link
Collaborator

@lstocchi lstocchi commented Jan 13, 2025

b525dc8#r1909010646 updated the gh workflow to run tests. However, it causes some tests to not being run anymore.
This patch re-add back the test command and filters the vfkit tests using the go build tag

it fixes #452

@lstocchi lstocchi requested review from cfergeau and evidolob January 13, 2025 14:04
Copy link
Collaborator

@cfergeau cfergeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

These testing targets deserve a larger overhaul at some point. We should be running all the tests which do not need virtualization on macos/linux/windows, and then run the tests which require virtualization on a linux runner since it is the only place where they can run.

Copy link
Contributor

openshift-ci bot commented Jan 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau, lstocchi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 56369d1 into containers:main Jan 13, 2025
20 checks passed
@cfergeau
Copy link
Collaborator

These testing targets deserve a larger overhaul at some point. We should be running all the tests which do not need virtualization on macos/linux/windows, and then run the tests which require virtualization on a linux runner since it is the only place where they can run.

I created #458 to track this.

@lstocchi lstocchi deleted the i452 branch January 13, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit tests are no longer run in github actions
2 participants