Dockerfile changes to build gvforwarder

[vyasgun]

Fixes: https://github.com/crc-org/crc-internal/issues/93

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vyasgun
Once this PR has been reviewed and has the lgtm label, please assign cfergeau for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cfergeau]

This also need to be built and pushed to quay, and to make sure bundles still work with this.

[cfergeau]

I would have expected that changing this line FROM registry.access.redhat.com/ubi9/go-toolset:1.22.9 AS build is enough to fix make image?
I'd use latest rather than a hardcoded version so that we don't need to update it too often.

[vyasgun]

I was running into errors while running the script so I put the fixes.
Changed the tag to latest

[cfergeau]

If I understand correctly, your changes allow to build from the images directory, eg cd images; podman build .
make image on the other hand attempts to build from the top level directory, not from images.
With your changes, this no longer works.

I'm fine with building from images as long as make image is updated and still works. It would be worth adding a check in github actions that the image can always be built, this does not seem to be tested at the moment.

[vyasgun]

yes, you're right - thanks! I changed the Dockerfile.

It would be worth adding a check in github actions that the image can always be built, this does not seem to be tested at the moment.

Something like this? (adding a target in the existing build check) or would it be better to have a separate check?