Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #2209 to release-5.29 branch #2252

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

mheon
Copy link
Member

@mheon mheon commented Jan 17, 2024

Backported #2209 to release-5.29 branch for Podman 4.9, as this is required for the podman farm build feature. Backporting features is unusual, but Podman 4.9 is a very unusual release (based on 4.8 instead of main), which makes this necessary.

I can, at least, say that we do not intend on making a habit out of this.

Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; for pedantic CI correctness let’s please wait until #2251 merges and rebase. (I don’t expect that to break anything but I think it’s better to let the tools work.)

@mheon
Copy link
Member Author

mheon commented Jan 17, 2024

Sure, can do.

@mtrmac mtrmac changed the base branch from main to release-5.29 January 17, 2024 19:37
@mtrmac
Copy link
Collaborator

mtrmac commented Jan 17, 2024

@mheon Also the PR was filed to merge to main; I have now retargeted it, but please double-check I didn’t break anything by that.

@mheon
Copy link
Member Author

mheon commented Jan 17, 2024

Looks OK, and the force-push for the rebase should clear any potential issues I missed

@mtrmac
Copy link
Collaborator

mtrmac commented Jan 17, 2024

#2251 merged, this can be rebased now.

Add support to push image with unknown digest and no tag to
a registry. This will be used by farm build to construct a list
of multi arch builds after pushing images built on each node.

Signed-off-by: Urvashi Mohnani <[email protected]>

MH: Backported to release-5.29 branch for Podman 4.9, as this is
required for the `podman farm build` feature. Backporting
features is unusual, but Podman 4.9 is a very unusual release
(based on 4.8 instead of main), which makes this necessary.

I can, at least, say that we do not intend on making a habit out
of this.

Signed-off-by: Matt Heon <[email protected]>
@mheon
Copy link
Member Author

mheon commented Jan 17, 2024

Rebased

Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@mtrmac mtrmac merged commit 1b5932f into containers:release-5.29 Jan 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants