Random storage-related cleanups #2287
Merged
Commits on Feb 8, 2024
-
Move the definition of storageImageCloser closer to its methods
Should not change behavior. Signed-off-by: Miloslav Trmač <[email protected]>
-
Define storageImageMetadata for the JSON in Image.Metadata
This way we: - have a single type, guaranteeing the source and destination don't get out of sync - separate the JSON-encoded data, without having to worry about Marshal/Unmarshal affecting unrelated fields of the source/destination. Should not change behavior. Signed-off-by: Miloslav Trmač <[email protected]>
-
Remove an unnecessary pointer in map values
First, it is unnecessary. Second, we will no longer need to worry about _allocating_ a variable to point to, or about pointing at a shared/volatile location. Signed-off-by: Miloslav Trmač <[email protected]>
-
Should not change behavior. Signed-off-by: Miloslav Trmač <[email protected]>
-
Simplify setting indexToStorageID
Now that we don't need pointer values, assign directly. This means we no longer confusingly use lastLayer _both_ for the parent layer and the currently-created layer. Signed-off-by: Miloslav Trmač <[email protected]>
-
Fail, instead of silently continuing, if a parent layer is not set yet
That should never happen, so make sure we notice. Signed-off-by: Miloslav Trmač <[email protected]>
-
Rename lastLayer to parentLayer
... now that it has that exclusive semantics. Should not change behavior. Signed-off-by: Miloslav Trmač <[email protected]>
-
Fix a comment documenting the locking rules
We only care about concurrency within the scope of HasThreadSafePutBlob. Should not change behavior. Signed-off-by: Miloslav Trmač <[email protected]>
-
Use digest.*.FromString where possible
... instead of doing the same thing manually. Should not change behavior. Signed-off-by: Miloslav Trmač <[email protected]>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.