DO NOT MERGE: Prototype setting image ID = manifest digest #2622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrmac
commented
Nov 6, 2024
Comment on lines
+1295
to
+1214
| // FIXME: With intendedID typically based on s.manifestDigest, this will fail if we ever fetch the same layer two different ways (with two different layer IDs | ||
| // per trustedLayerIdentityData), e.g. if we see the layer/images across graph drivers which do/don’t support partial pulls. | ||
| // The only way to recover would be to remove the other image, and that might not be possible. |
There was a problem hiding this comment.
FWIW this also completely rules out the capability to make partial pulls optional. If we want a single view of each image, we have to actually only produce a single view.
Heed the FIXME. Signed-off-by: Miloslav Trmač <[email protected]>
mtrmac
force-pushed
the
image-id-manifest-digest
branch
from
f5a1466
to
edb347e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cc: @giuseppe