cirrus: save/restore golangci-lint cache for linux #2832
Conversation
kolyshkin
force-pushed
the
golangci-lint-cache
branch
from
86b938b to
5fc4dad
Compare
This shaves off some time (40 seconds, ~15%) from a validate job (unless either golangci-lint or go version changes). The cache size is pretty small (currently 686Kb compressed). Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
force-pushed
the
golangci-lint-cache
branch
from
5fc4dad to
284222e
Compare
There was a problem hiding this comment.
Thanks!
This is interesting, and some experiments in #2837 suggest that there might be much more.
… and there are potentially quite a few other things that could be cleaned up and sped up in the tests. That’s clearly not this PR, but it might be something we could ask for help with, from a CI specialist.
| golangci-lint_cache: | ||
| folder: /root/.cache/golangci-lint | ||
| reupload_on_changes: true | ||
| fingerprint_script: |
There was a problem hiding this comment.
Looking at https://github.com/golangci/golangci-lint-action?tab=readme-ov-file#caching-internals , is this sufficient?
I do think the two existing values are relevant, but invalidating also on go.mod (go.sum??) seems reasonable. Compare also https://github.com/containers/image/pull/2837/files#r2054800484 about regular refreshes.
reupload_on_changes does help against missing updates, but it is not optimal for efficiency, e.g. if we branch and the two branches differ in code but not (yet) in tool versions — the reupload + the same fingerprint would cause the two branches to stop on each others’ caches.
| @@ -14,5 +14,5 @@ linters: | |||
| exclusions: | |||
| presets: | |||
| - comments | |||
| - common-false-positives | |||
| # - common-false-positives | |||
This shaves off some time from golangci-lint run (unless either golangci-lint or go version changes).
The cache size is pretty small (a few MB).