Fix unitialized access of err and erroneous error message. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have a proper setup to test this yet for regressions, so I didn't build it. Again, I apologize if the changes are too pedantic. |
haesbaert
force-pushed
the
haesbaert
branch
2 times, most recently
from
63af27a to
bf4cca5
Compare
|
Hi! Thanks a lot for taking the interest in working on this. Your changes look good to me, just a couple of comments:
|
malloc(3) already sets errno and we should return on NULL. Signed-off-by: Christiano Haesbaert <[email protected]>
Saves you headache when stdout is not a tty. Signed-off-by: Christiano Haesbaert <[email protected]>
Preparation for a couple of fixes/improvements, these are only re-indents and some tabs vs spaces so that the next commit intention is clear. Signed-off-by: Christiano Haesbaert <[email protected]>
o Make sure we print errors and warnings to stderr. o Don't assume fork succeeds. o Use err(3) and warn(3), cuts some lines. o Keep braces for single liners as requested. Signed-off-by: Christiano Haesbaert <[email protected]>
|
Thanks for reviewing it. |
haesbaert
requested review from
crobinso,
mtjhrc and
tylerfanelli
as code owners
|
@haesbaert There seems to be some conflicts with this PR as a lot has been done since its submission. Do you mind rebasing on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
malloc(3) already sets errno and we should return on NULL.
Hi, sorry if this is too silly I was just going over the code and noticed it, also you could use err(3) or errx(3) and cut some lines.
I have more silly fixes like this I can push if you want.