Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime-spec: use version v1.2.0 and bump other deps. #131

Merged
merged 1 commit into from
Mar 2, 2024
Merged

runtime-spec: use version v1.2.0 and bump other deps. #131

merged 1 commit into from
Mar 2, 2024

Conversation

flouthoc
Copy link
Collaborator

@flouthoc flouthoc commented Mar 1, 2024

PR bumps specs so libocispec can runtime-spec version v1.2.0 and also bumps image-spec and yajl with it.

@flouthoc
Copy link
Collaborator Author

flouthoc commented Mar 1, 2024

@giuseppe PTAL

@flouthoc flouthoc marked this pull request as draft March 1, 2024 18:42
@flouthoc
Copy link
Collaborator Author

flouthoc commented Mar 1, 2024

I still have to check this with crun so putting on draft.

giuseppe
giuseppe approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

please merge once green

@flouthoc flouthoc marked this pull request as ready for review March 2, 2024 03:51
@flouthoc
Copy link
Collaborator Author

flouthoc commented Mar 2, 2024

Ok crun compiles so merging this one.

@flouthoc flouthoc merged commit f76be64 into containers:main Mar 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giuseppe giuseppe giuseppe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flouthoc @giuseppe