Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to json c #157

Open
wants to merge 3 commits into
base: switch-to-c-json
Choose a base branch
from
Open

Conversation

xw19
Copy link

@xw19 xw19 commented Jan 19, 2025

Switch to json-c

Ref #138

saschagrunert and others added 2 commits January 7, 2025 22:03
This is the first step in migrating from yajl to jansson. We now enable
to link it in the same way and add it as dependency to the project.

Signed-off-by: Sascha Grunert <[email protected]>
Added a temporary function to yajl_val to json_t
converted YAJL_GET_STRING to json_string_value
converted YAJL_IS_NUMBER to json_is_number
added functions from double to various int types.
YAJL_GET_NUMBER returns string. While json_number_value returns double.

Signed-off-by: Sourav Moitra <[email protected]>
@xw19 xw19 changed the base branch from main to switch-to-c-json January 27, 2025 16:25
@xw19 xw19 force-pushed the switch-to-json-c branch 6 times, most recently from 63f509b to 205c26a Compare January 29, 2025 18:39
Signed-off-by: Sourav Moitra <[email protected]>
@xw19 xw19 force-pushed the switch-to-json-c branch from 205c26a to 7712b0f Compare January 29, 2025 18:55
@giuseppe
Copy link
Member

giuseppe commented Feb 3, 2025

@xw19 is it good to merge? Or are we waiting for something more?

@xw19
Copy link
Author

xw19 commented Feb 3, 2025

@giuseppe Some of the cpu arch are failing the tests need some help to figure them out. I need some more time to figure them out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants