Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-action: update charts path to include memtierd and memory-qos #129

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

fmuyassarov
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmuyassarov
Copy link
Collaborator Author

fmuyassarov commented Oct 10, 2023

Requires #127 and #128.
Please don't merge this PR before ^.

Copy link
Collaborator

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marquiz
Copy link
Collaborator

marquiz commented Oct 10, 2023

Needs rebase

Currently TA and Balloons plugins Helm charts are under
deployment/helm/resource-management-policies/ while memtierd
and memory-qos is deployment/helm/. There is no reason to have
such a tree and it makes releasing process complicated. Instead
keep them all under the same directory deployment/helm/. This
doesn't change the name of the TA and Balloons plugins charts
at all. As such, no user/installation change.

Signed-off-by: Feruzjon Muyassarov <[email protected]>
@fmuyassarov
Copy link
Collaborator Author

fmuyassarov commented Oct 10, 2023

Needs rebase

Done and ready to be merged I think.

@marquiz marquiz merged commit b6c4b21 into containers:main Oct 10, 2023
3 checks passed
@fmuyassarov fmuyassarov deleted the fix-ga branch October 10, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants