Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.3/#231] fixes: rename default config group label, support/fall back to deprecated labels. #232

Merged

Conversation

klihub
Copy link
Collaborator

@klihub klihub commented Jan 12, 2024

Backport of #231 to the 0.3 release branch.

To avoid inconveniences with some existing tooling, change the
default configuration group label to 'prefix.domain/key' format.

Signed-off-by: Krisztian Litkey <[email protected]>
Fall back to looking for deprecated group labels if the default or
configured one is not found.

Signed-off-by: Krisztian Litkey <[email protected]>
Copy link
Collaborator

@askervin askervin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klihub klihub merged commit 55e0563 into containers:release-0.3 Jan 15, 2024
3 checks passed
@klihub klihub deleted the backports/release-0.3/config-group-labels branch January 15, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants