instrumentation: fix resource creation, use parent-based sampler. #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a small typo: s/jeager/jaeger, otherwise LGTM |
The jaeger-specific exporter was dropped in Opentelemetry after 1.17.0. Let's drop support for it, too. Signed-off-by: Krisztian Litkey <[email protected]>
Use resource.New*() to create our OpenTelemetry resource as opposed to Merge()ing with resource.Default(). This should avoid hitting the annoying semconv schema snafu (open-telemetry/opentelemetry-go#4476) which we'd otherwise hit if/when the default semconv version is bumped. Signed-off-by: Krisztian Litkey <[email protected]>
If we have a tracing enabled, we always want to sample spans whenever - our own probabilistic sampler says so, or - we have a parent span and it is being sampled Therefore use a parent-based probabilistic sampler instead of just a probabilistic one. Signed-off-by: Krisztian Litkey <[email protected]>
klihub
force-pushed
the
fixes/otel-tracing
branch
from
afd096d
to
55bcc99
Compare
Thanks for spotting it. I keep doing that same mistake both in code comments and commit messages. I blame it on Chuck Y. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a few annoyances in our current OpenTelemetry instrumentation code. In particular, it