balloons: allow assigning containers to balloons by runtime-evaluated expressions. #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klihub
force-pushed
the
devel/assign-balloons-by-expression
branch
2 times, most recently
from
02f490f
to
b940530
Compare
klihub
force-pushed
the
devel/assign-balloons-by-expression
branch
from
caec3d1
to
1703d85
Compare
askervin
reviewed
Feb 13, 2024
fmuyassarov
reviewed
Feb 13, 2024
klihub
force-pushed
the
devel/assign-balloons-by-expression
branch
from
1703d85
to
36aff44
Compare
klihub
force-pushed
the
devel/assign-balloons-by-expression
branch
from
36aff44
to
1f1a98f
Compare
askervin
reviewed
Feb 13, 2024
klihub
force-pushed
the
devel/assign-balloons-by-expression
branch
4 times, most recently
from
30cd686
to
cccfe59
Compare
klihub
force-pushed
the
devel/assign-balloons-by-expression
branch
2 times, most recently
from
e7c6a2a
to
2e1bf8d
Compare
I got fooled by your comment for a moment, too. So there is not need to be... 🙈 |
klihub
force-pushed
the
devel/assign-balloons-by-expression
branch
from
2e1bf8d
to
78085b1
Compare
klihub
force-pushed
the
devel/assign-balloons-by-expression
branch
4 times, most recently
from
0477c87
to
9e01c9e
Compare
Implement assigning containers to balloon instances by
container match expression defined in balloon definitions.
Match expressions are evaluated for containers which are
not explicitly assigned to any balloon by an annotation,
before namespace-based assignments. If an expression in a
balloon definition matches a container, that container is
assigned to a balloon instance of that definition.
For instance, given this balloon definition among the
configuration
...
balloonTypes:
- name: specialBalloon
matchExpressions:
- key: pod/labels/app.kubernetes.io/component
operator: Equals
values: [ "SpecialComponent" ]
...
any container not explicitly annotated to some other balloon
will get assigned to instances of specialBalloon, if the pod
of the container has the label
app.kubernetes.io/component=SpecialComponent
Similarly, given this balloon definition among the
configuration
...
balloonTypes:
- name: podBalloon
matchExpressions:
- key: pod/name
operator: In
values: [ "pod1", "pod2", "pod3" ]
...
all containers of pods named pod1, pod2, and pod3 will be
assigned to instances of podBalloon.
Signed-off-by: Krisztian Litkey <[email protected]>
Implement custom validation for balloons. The custom validator validates all container match expressions found in any of the balloon definitions. Signed-off-by: Krisztian Litkey <[email protected]>
Signed-off-by: Krisztian Litkey <[email protected]>
Signed-off-by: Krisztian Litkey <[email protected]>
klihub
force-pushed
the
devel/assign-balloons-by-expression
branch
from
9e01c9e
to
3b9fbf9
Compare
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
Implement assigning containers to balloon instances by container match expression defined in balloon definitions. Match expressions are evaluated for containers which are not explicitly assigned to any balloon by an annotation, before namespace-based assignments. If an expression in a balloon definition matches a container, that container is assigned to a balloon instance of that definition.
For instance, given this balloon definition among the configuration
any container not explicitly annotated to some other balloon will get assigned to instances of specialBalloon, if the pod of the container has the label
app.kubernetes.io/component=SpecialComponentSimilarly, given this balloon definition among the configuration
all containers of pods named pod1, pod2, and pod3 will be assigned to instances of podBalloon.