Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sysfs: survive NUMA nodes without memory. #339

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

klihub
Copy link
Collaborator

@klihub klihub commented Jun 21, 2024

Don't fail for CPU-only NUMA nodes. Treat them as DRAM nodes with 0 bytes of memory attached, but exclude them when calculating average memory size for memory type approximation.

pkg/sysfs/system.go Show resolved Hide resolved
pkg/sysfs/system.go Outdated Show resolved Hide resolved
@klihub klihub requested a review from askervin June 24, 2024 08:20
Don't fail for CPU-only NUMA nodes. Treat them as DRAM nodes with 0
bytes of memory attached, but exclude them when calculating average
memory size for memory type approximation.

Signed-off-by: Krisztian Litkey <[email protected]>
Copy link
Collaborator

@askervin askervin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klihub klihub merged commit b98a12a into containers:main Jun 25, 2024
2 checks passed
@klihub klihub deleted the fixes/memless-numa-nodes branch June 25, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants