-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
balloons: add support for isolated cpus. #344
Conversation
1e96e8a
to
97d7f4a
Compare
97d7f4a
to
d013a98
Compare
b236ab8
to
f54d190
Compare
test/e2e/policies.test-suite/balloons/n4c16/test22-isolcpus/code.var.sh
Outdated
Show resolved
Hide resolved
test/e2e/policies.test-suite/balloons/n4c16/test22-isolcpus/balloons-isolcpus.cfg
Show resolved
Hide resolved
test/e2e/policies.test-suite/balloons/n4c16/test22-isolcpus/code.var.sh
Outdated
Show resolved
Hide resolved
f54d190
to
2428f93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once all review comments are addressed I'm happy with this as soon as @askervin finds it good to go in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: spotted a typo in documentation.
test/e2e/policies.test-suite/balloons/n4c16/test22-isolcpus/code.var.sh
Outdated
Show resolved
Hide resolved
test/e2e/policies.test-suite/balloons/n4c16/test22-isolcpus/code.var.sh
Outdated
Show resolved
Hide resolved
test/e2e/policies.test-suite/balloons/n4c16/test22-isolcpus/code.var.sh
Outdated
Show resolved
Hide resolved
test/e2e/policies.test-suite/balloons/n4c16/test22-isolcpus/code.var.sh
Outdated
Show resolved
Hide resolved
test/e2e/policies.test-suite/balloons/n4c16/test22-isolcpus/code.var.sh
Outdated
Show resolved
Hide resolved
test/e2e/policies.test-suite/balloons/n4c16/test22-isolcpus/code.var.sh
Outdated
Show resolved
Hide resolved
test/e2e/policies.test-suite/balloons/n4c16/test22-isolcpus/code.var.sh
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a number of new review comments and suggestions related to the e2e test framework additions and the test scriptlet itself.
2428f93
to
ad63fc1
Compare
9fb9999
to
64da112
Compare
41aea96
to
15082f2
Compare
15082f2
to
eb27c6d
Compare
test/e2e/policies.test-suite/balloons/n4c16/test22-isolcpus/code.var.sh
Outdated
Show resolved
Hide resolved
eb27c6d
to
366b2b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
test/e2e/policies.test-suite/balloons/n4c16/test22-isolcpus/code.var.sh
Outdated
Show resolved
Hide resolved
test/e2e/policies.test-suite/balloons/n4c16/test22-isolcpus/code.var.sh
Outdated
Show resolved
Hide resolved
test/e2e/policies.test-suite/balloons/n4c16/test22-isolcpus/code.var.sh
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After passed test pod0 is left behind:
vagrant@n4c16-generic-ubuntu2204-containerd:~$ kubectl get pods -A
NAMESPACE NAME READY STATUS RESTARTS AGE
default pod0 2/2 Running 2 (92s ago) 2m10s
...
@klihub already suggested changes to cleanup()
so that nothing is left behind if the test passed.
366b2b9
to
bcfe280
Compare
|
0a38247
to
05dc6c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be a risk of failing next tests if this passes.
test/e2e/policies.test-suite/balloons/n4c16/test22-isolcpus/code.var.sh
Outdated
Show resolved
Hide resolved
05dc6c8
to
d683894
Compare
Signed-off-by: Feruzjon Muyassarov <[email protected]>
Signed-off-by: Feruzjon Muyassarov <[email protected]>
d683894
to
c0db2d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for this new feature, @fmuyassarov!
The isolcpus boot parameter allows you to isolate specific CPUs from
the general SMP balancing and scheduler algorithms. Currently, when a
balloon picks up CPUs, it does not differentiate between isolated and
non-isolated CPUs. This change improves the balloon's logic to: