balloons: add support for power efficient & high performance cores #354
Conversation
fmuyassarov
requested review from
askervin,
klihub and
kad
and removed request for
askervin
fmuyassarov
force-pushed
the
p/e-cores
branch
2 times, most recently
from
2aad4db
to
ccbafbc
Compare
fmuyassarov
changed the title
klihub
dismissed
their stale review
A few remaining things to fix as mentioned in the review comments...
This commit introduces a new field in the balloons configuration CR, enabling users to specify their efficient/performance core preferences for their workloads. When a user explicitly requests efficient or performance cores, the policy will attempt to allocate according to the user preferences. If the request cannot be satisfied, the policy will fall back to other available cores on the host. If a user adds `preferIsolCpus` in addition to specifying coreTypes, the policy will prioritize allocating isolated CPUs cores over the preferred efficient/performance cores, in case these sets are different. Signed-off-by: Feruzjon Muyassarov <[email protected]>
Signed-off-by: Feruzjon Muyassarov <[email protected]>
fmuyassarov
force-pushed
the
p/e-cores
branch
from
8661691
to
8636d92
Compare
|
@fmuyassarov Just to make sure I understand the latest changes: we have explicit positive preferences but no implied negative ones, right ? IOW: a core type preference is simply translated to a virtual device close to the right types of cores, but we don't try to generate/inject avoided virtual devices to avoid taking cores of non-preferred types. Is this correct ? |
That's right. Basically, try to use cores of the preferred device as much as we can if not we continue to use non-preferred ones. |
Thanks ! I am happy with this. Let's wait for @askervin to check if his concerns have now all been addressed. |
Introduce a new parameter
coreTypein Balloons policy for allowing users to express their preference of selecting P-high performance or power efficient cores.