e2e: bridge CNI setup fixes for Fedora/containerd. #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askervin
reviewed
Sep 19, 2024
klihub
force-pushed
the
fixes/bridge-cni-fixes
branch
from
af298ad
to
3d12a01
Compare
Thanks for spotting that ! My tree was not up-to-date, missing your regexp pattern fix commit (plus instead of moving that block earlier it was accidentally copying it). So it recreated the other bug you just fixed and it wouldn't have worked at all. Let me put up an e2e test run to double-check that this committed and pushed version works... |
Okay, it looks good. Spun up the VM and the cluster and successfully ran all tests. |
kad
approved these changes
Sep 20, 2024
pfl
approved these changes
Sep 20, 2024
Signed-off-by: Krisztian Litkey <[email protected]>
When using the bridge plugin, configure it earlier, right after the basic runtime configuration has been created, before NRI is enabled or the runtime restarted. This should make it sure that the node does not linger in a NotReady state causing false test failures. Signed-off-by: Krisztian Litkey <[email protected]>
klihub
force-pushed
the
fixes/bridge-cni-fixes
branch
from
3d12a01
to
e2b4e2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix e2e tests runnning with bridge CNI plugin on fedora. In particular,
These fixes should ensure that the node does not stay lingering in NotReady state, causing false test failures/positives.