Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: verify in smaller steps, verify binary builds. #364

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

klihub
Copy link
Collaborator

@klihub klihub commented Sep 20, 2024

Use a separate workflow step for deps, formatting and code generation. Add missing verification of binary builds.

@klihub klihub force-pushed the fixes/ci/verify-binary-builds branch 2 times, most recently from dd2420b to 1f96475 Compare September 20, 2024 06:51
@klihub klihub changed the title build: add missing verification of binary builds in CI. CI: verify in smaller steps, verify binary builds. Sep 20, 2024
@klihub klihub force-pushed the fixes/ci/verify-binary-builds branch from 1f96475 to c41ecb3 Compare September 20, 2024 06:54
Copy link
Collaborator

@kad kad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Add missing verification of binary builds. Run verifications
in CI one at a time for more granular error reports. Update
the collective verify build target to run all verifications
in a single go.

Signed-off-by: Krisztian Litkey <[email protected]>
Copy link
Collaborator

@askervin askervin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the clarification!

LGTM

@askervin askervin merged commit 542fe43 into containers:main Sep 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants