balloons: improve handling of containers with no CPU requests #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antti Kervinen <[email protected]>
- Change chooseBalloonInstance() to fillableBalloonInstances() returning multiple balloon instances that can be chosen. - Add a separate logic for choosing a balloon instance among fillable ones. This changes current container-to-balloon assigning behavior. Instead of choosing the first balloon instance where a container fits, now choose the one with most room in it, and secondly, least containers in it. This fixes the issue in the earlier logic that caused containers without CPU requests to always pile up in the same balloons. Now they are spread evenly to several balloons that have the same amount of free CPUs. Signed-off-by: Antti Kervinen <[email protected]>
If a new balloon is created for a container that has no CPU requests, CPU allocation of "requested" 0 CPUs succeeds without allocating anything. That would lead to a balloon with empty cpuset, that is, no CPU pinning for containers in it. Signed-off-by: Antti Kervinen <[email protected]>
Signed-off-by: Antti Kervinen <[email protected]>
klihub
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Containers without CPU requests always pile up to the first balloon where they fit.
This patch enables having multiple balloons in the system so that this kind of containers will be spread equally into them.
This patch is an enabler to fix the issue #385.