Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: installtion instructions updates according to the Helm charts changes #74

Merged
merged 3 commits into from
Jun 22, 2023

Conversation

fmuyassarov
Copy link
Collaborator

We have removed the defaulting of the namespace and instead let the users to dictate what namespace they wish to use for installing the Helm chart into.

@fmuyassarov
Copy link
Collaborator Author

cc @marquiz

@fmuyassarov fmuyassarov marked this pull request as draft June 21, 2023 07:52
@fmuyassarov fmuyassarov marked this pull request as ready for review June 21, 2023 08:05
We have removed the defaulting of the namespace and instead let
the users to dictate what namespace they wish to use for installing
the Helm chart into.

Signed-off-by: Feruzjon Muyassarov <[email protected]>
We have decided to remove some of the values of the Helm chart
and as such updating the user doc accordingly.

Signed-off-by: Feruzjon Muyassarov <[email protected]>
@fmuyassarov
Copy link
Collaborator Author

Rebased on top of the HEAD

Copy link
Collaborator

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fmuyassarov fmuyassarov changed the title helm: require users to explicitly specify the namespace docs: installtion instructions updates according to the Helm charts changes Jun 22, 2023
@jukkar jukkar merged commit f3f5ef2 into containers:main Jun 22, 2023
@fmuyassarov fmuyassarov deleted the helm-namespace branch June 22, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants