github/workflows: fix broken yaml #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marquiz
force-pushed
the
devel/github-workflow
branch
6 times, most recently
from
0d6540d
to
1a2e5fb
Compare
klihub
approved these changes
Jun 21, 2023
klihub
requested changes
Jun 21, 2023
|
@marquiz I mean I screwed up my earlier review of your PR where I was wondering about the same but I was hasty and approved it. Then it went in, although I think it should never have. We have another workflow already in place which is dealing exclusively with publishing documentation. It is this publish-docs.yaml. I think it would be better to stick with that (it is basically the same as you added) and make fixes there. |
No, that one is about actually publishing the docs. This one just verifies that the docs are buildable and that the gh-pages update script doesn't fail. |
Fix yaml syntax that got broken in 19bbdd5. Signed-off-by: Markus Lehtonen <[email protected]>
In addition to simplification this is required for the docs and bh-pages checks to be able to run. Signed-off-by: Markus Lehtonen <[email protected]>
marquiz
force-pushed
the
devel/github-workflow
branch
from
1a2e5fb
to
4ba7abf
Compare
klihub
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix yaml syntax that got broken in
19bbdd5.
In addition there's another (required) patch to simplify the workflow file.