Helm improvments #85
Helm improvments #85
Conversation
|
Here is the GitHub action result of the first linter run: https://github.com/containers/nri-plugins/actions/runs/5377726551/jobs/9756576779?pr=85 |
This commit adds a simple github action which runs helm lint for balloons and topology-aware plugins. Signed-off-by: Feruzjon Muyassarov <[email protected]>
When installing the Helm chart, it is important to explicitly specify the desired namespace for installation. It should be noted that failing to specify the namespace will result in the Helm chart installing the manifests in the default namespace. Signed-off-by: Feruzjon Muyassarov <[email protected]>
fmuyassarov
force-pushed
the
ga-helm-linter
branch
from
f54f64a
to
ca2349c
Compare
|
@fmuyassarov The PR as such looks fine to me. That said, I have a tangentially related question now that I look at the changes: Shouldn't/couldn't we, please, have a helm chart for the template policy as well ? One of the main points of the template policy is that it serves as a |
There was a problem hiding this comment.
This LGTM, but please @jukkar, @fmuyassarov take a look at a my related question.
I can definitely add chart for the template policy + kustomize installation. Would you like that to happen on this PR or shall I send a seperate PR for that (personally I prefer to have separate PR)? |
Makes sense, +1 to this. |
|
Yes, I also think separate PR is fine. |
This PR adds a GitHub action for linting Helm charts on pull requests and fixes minor issue with namespaces in the Helm chart installation guide.
Helm linter is basically validating helm chart values in a chart's values.yaml file with JSON schemas.