instrumentation: use a more appropriate propagator. #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jukkar
reviewed
Jun 26, 2023
klihub
force-pushed
the
fixes/trace-propagator
branch
from
530e3c0
to
3c32e1a
Compare
Use a correct propagator for ttRPC (and gRPC) span propagation. Without this, ttRPC (or gRPC) span information are not properly transmitted over the IPC. As a side effect, spans generated at the RPC server end of the IPC do not get properly nested under the related spans generated on the originator side. Signed-off-by: Krisztian Litkey <[email protected]>
klihub
force-pushed
the
fixes/trace-propagator
branch
from
3c32e1a
to
d4662a2
Compare
jukkar
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a correct propagator for ttRPC (and gRPC) span propagation. Without this, ttRPC (or gRPC) span information are not properly transmitted over the IPC. As a side effect, spans generated at the RPC server end of the IPC do not get properly nested under the related spans generated on the originator side.