Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Read pod name from podman create args #89

Merged
merged 3 commits into from
Sep 24, 2024
Merged

fix: Read pod name from podman create args #89

merged 3 commits into from
Sep 24, 2024

Commits on Jul 9, 2024

  1. fix: Read pod name from podman create args 

    Signed-off-by: Ananth Bhaskararaman <[email protected]>
    @ananthb
    ananthb committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    c806b4a View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2024

  1. fix: Require one of name or name_positional 

    Signed-off-by: Ananth Bhaskararaman <[email protected]>
    @ananthb
    ananthb committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    a3009d0 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. fix(pod): only set PodName= when --name is used 

    Only set `PodName=` Quadlet option when `--name` is used per the
discussion in containers#88.

Renamed `name` to `name_flag`.

Moved `name_flag` so that it matches the `PodName=` position on
podman-systemd.unit(5) man page.

Added more user-friendly documentation to `name_flag` help text.

Set `long = "name"` and `short` arg attributes for `name_flag`.

Refactored `Pod::name()` a bit to use more destructuring and
`Option::as_deref()`.

Signed-off-by: Paul Nettleton <[email protected]>
    @k9withabone
    k9withabone committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    cc00d45 View commit details
    Browse the repository at this point in the history