Skip to content

Commit

Permalink
disk: Also pass stdin to install container
Browse files Browse the repository at this point in the history
It's only by doing this that we end up calling into the
code inside `attach()` that tries to ensure the terminal
size matching. Otherwise we just get the default of 80
columns (and no dynamic SIGWINCH resizing).

This fixes the output in containers/bootc#655

Signed-off-by: Colin Walters <[email protected]>
  • Loading branch information
cgwalters committed Jul 3, 2024
1 parent a483a8b commit fedcf86
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/bootc/bootc_disk.go
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ func (p *BootcDisk) runInstallContainer(quiet bool, config DiskImageConfig) (err
var exitCode int32
if !quiet {
attachOpts := new(containers.AttachOptions).WithStream(true)
if err := containers.Attach(attachCancelCtx, p.bootcInstallContainerId, nil, os.Stdout, os.Stderr, nil, attachOpts); err != nil {
if err := containers.Attach(attachCancelCtx, p.bootcInstallContainerId, os.Stdin, os.Stdout, os.Stderr, nil, attachOpts); err != nil {
return fmt.Errorf("attaching: %w", err)
}
}
Expand Down

0 comments on commit fedcf86

Please sign in to comment.