Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:BUILD] FCOS image: enable nightly build #20134

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Sep 25, 2023

wait-for-copr is still very flaky and has failed more often than not. Ref: fedora-copr/copr#2819

This change to the fcos GHA will allow nightly builds pulling in whatever packages exist on podman-next at that time without depending on wait-for-copr.

The commit id will still be recorded in podman version as well as the image tag, so auditing is not affected with this change.

[NO NEW TESTS NEEDED]

Does this PR introduce a user-facing change?

None

`wait-for-copr` is still very flaky and has failed more often than not.
Ref: fedora-copr/copr#2819

This change to the fcos GHA will allow nightly builds pulling in
whatever packages exist on podman-next at that time without depending on
wait-for-copr.

The commit id will still be recorded in podman version as well as the
image tag, so auditing is not affected with this change.

[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <[email protected]>
@openshift-ci openshift-ci bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 25, 2023
@lsm5
Copy link
Member Author

lsm5 commented Sep 25, 2023

@cevich PTAL. I guess the prepush GHA can also be clubbed into this one using conditionals, but I can leave that for later.

@lsm5
Copy link
Member Author

lsm5 commented Sep 25, 2023

cc @benoitf

@benoitf
Copy link
Contributor

benoitf commented Sep 25, 2023

still better than nothing 👍

@mheon
Copy link
Member

mheon commented Sep 25, 2023

LGTM

Copy link
Member

@cevich cevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 8a16174 into containers:main Sep 25, 2023
44 checks passed
@lsm5
Copy link
Member Author

lsm5 commented Sep 26, 2023

weird why wait-for-copr was triggered in the scheduled run: https://github.com/containers/podman/actions/runs/6306371287/job/17121402667 . Needs yet another followup I guess 😞

@cevich
Copy link
Member

cevich commented Sep 26, 2023

weird why wait-for-copr was triggered in the scheduled run:

GHA conditions DO NOT operate as you would expect. Oh and the docs are terrible. IIRC, the key is they always evaluate to strings (or something like that). Sadly, you may need to play with them in the sandbox (or elsewhere) to get them working. Maybe try:

if: ${{ github.event_name != 'schedule' }}

?

@lsm5
Copy link
Member Author

lsm5 commented Sep 26, 2023

weird why wait-for-copr was triggered in the scheduled run:

GHA conditions DO NOT operate as you would expect. Oh and the docs are terrible. IIRC, the key is they always evaluate to strings (or something like that). Sadly, you may need to play with them in the sandbox (or elsewhere) to get them working. Maybe try:

if: ${{ github.event_name != 'schedule' }}

?

yes #20153

@lsm5 lsm5 deleted the fcos-image-cron branch September 26, 2023 14:10
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Dec 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants