Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix image filters parsing #21260

Merged
merged 4 commits into from
Jan 28, 2024
Merged

Fix image filters parsing #21260

merged 4 commits into from
Jan 28, 2024

Commits on Jan 25, 2024

  1. Vendor in latest c/common 

    Pull in updates made to the filters code for
images. Filters now perform an AND operation
except for th reference filter which does an
OR operation for positive case but an AND operation
for negative cases.

Signed-off-by: Urvashi Mohnani <[email protected]>
    @umohnani8
    umohnani8 committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    7c8c945 View commit details
    Browse the repository at this point in the history

  2. Fix image filters parsing 

    Fix the image filter parsing in the common libraries
to follow an AND logic for all filters passed in ensuring
compatibility with Docker behavior.
Also fix the filter parsing on the tunnel side so that we grab
all the filters given by the user and not only the last filter
in the list.
Add tests for the fixes.

Signed-off-by: Urvashi Mohnani <[email protected]>
    @umohnani8
    umohnani8 committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    90867d9 View commit details
    Browse the repository at this point in the history

  3. Fix auto-update digest comparison 

    Since images can have multiple digests, it is better
to compare the image ID as that will definitely change
on an update and each image can only have one ID.

Signed-off-by: Urvashi Mohnani <[email protected]>
    @umohnani8
    umohnani8 committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    848078c View commit details
    Browse the repository at this point in the history

  4. Fix inspect test that rely on digest 

    Given that we can have multiple image digests,
fix the inspect test to check whether the digest
given matches one of the digests of the image.

Signed-off-by: Urvashi Mohnani <[email protected]>
    @umohnani8
    umohnani8 committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    202cab6 View commit details
    Browse the repository at this point in the history