Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

volume ls: fix race that caused it to fail #24479

Merged
merged 1 commit into from
Nov 6, 2024

Commits on Nov 6, 2024

  1. volume ls: fix race that caused it to fail

    If volume ls was called while another volume was removed at the right
    time it could have failed with "no such volume" as we did not ignore
    such error during listing. As we list things and this no longer exists
    the correct thing is to ignore the error and continue like we do with
    containers, pods, etc...
    
    This was pretty easy to reproduce with these two commands running in
    different terminals:
    while :; do bin/podman volume create test && bin/podman volume rm test || break; done
    while :; do bin/podman volume ls || break ; done
    
    I have a slight feeling that this might solve containers#23913 but I am not to
    sure there so I am not adding a Fixes here.
    
    Signed-off-by: Paul Holzinger <[email protected]>
    Luap99 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    9a0c0b2 View commit details
    Browse the repository at this point in the history