spec: clamp rlimits without CAP_SYS_RESOURCE #24696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuseppe
added
the
No New Tests
openshift-ci
bot
added
release-note
approved
|
I've not added a test as it requires to run without a capability |
Luap99
reviewed
Nov 27, 2024
giuseppe
force-pushed
the
clamp-ulimits-root-no-sys-resource
branch
from
c447288 to
4b38031
Compare
Luap99
reviewed
Nov 27, 2024
commit 5ebba75 implemented this behaviour for rootless users and later commit 0a69aef changed it when in a user namespace, but the same limitation exists for root without CAP_SYS_RESOURCE. Change the check to use the clamp to the current values if running without CAP_SYS_RESOURCE. Closes: containers#24692 Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
clamp-ulimits-root-no-sys-resource
branch
from
4b38031 to
4b38294
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, lsm5, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit 5ebba75 implemented this behaviour for rootless users and later commit
0a69aef changed it when in a user namespace, but the same limitation exists for root without CAP_SYS_RESOURCE. Change the check to use the clamp to the current values if running without CAP_SYS_RESOURCE.
Closes: #24692
Does this PR introduce a user-facing change?