Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify runtimeVersion to return first line #321

Closed
wants to merge 1 commit into from
Closed

modify runtimeVersion to return first line #321

wants to merge 1 commit into from

Conversation

123456890987654321
Copy link
Contributor

@123456890987654321 123456890987654321 commented Jan 9, 2025 •
edited
Loading

runtimeVersion() is returning invalid version :

# HELP podman_system_runtime_version Podman system runtime version.
# TYPE podman_system_runtime_version gauge
podman_system_runtime_version{version="runc version 1.1.12\nspec"} 1

Proposed change returns valid version :

# HELP podman_system_runtime_version Podman system runtime version.
# TYPE podman_system_runtime_version gauge
podman_system_runtime_version{version="runc version 1.1.12"} 1

@123456890987654321 123456890987654321 mentioned this pull request Jan 9, 2025
Closed
@navidys
Copy link
Collaborator

navidys commented Jan 9, 2025

Hi @123456890987654321
Thanks for the PR.

Can u also sign your commit ? DCO checking is failing

Regards

@123456890987654321
Copy link
Contributor Author

apologies, didn't notice the GPG key was not configured. will fix it. Thank You

@123456890987654321 123456890987654321 deleted the 123456890987654321-runtimeVersion branch January 9, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@123456890987654321 @navidys