Fix current run-test-e2e

Currently tests are not using packit repo created by previous steps Added an option for scripts --use-qm-copr to be used while running tests with rhcontainerbot/qm, default is using packit rpms, triggered by scenario=manual parsed in context scenario == manual Signed-off-by: Yariv Rachmani <[email protected]>
containers · Dec 19, 2023 · 4eb618c · 4eb618c
1 parent 3019b2e
commit 4eb618c
Show file tree

Hide file tree

Showing 8 changed files with 69 additions and 31 deletions.
diff --git a/.packit.yaml b/.packit.yaml
@@ -64,7 +64,6 @@ jobs:
     trigger: pull_request
     identifier: e2e-tiers
     tmt_plan: /plans/e2e/tier-0
-    skip_build: true
     targets:
     - centos-stream-9-x86_64
     tf_extra_params:
@@ -78,7 +77,6 @@ jobs:
     trigger: pull_request
     identifier: e2e-ffi
     tmt_plan: /plans/e2e/ffi
-    skip_build: true
     targets:
     - centos-stream-9-x86_64
     tf_extra_params:

diff --git a/plans/e2e/ffi.fmf b/plans/e2e/ffi.fmf
@@ -22,7 +22,7 @@ adjust:
            # qm-setup-from-gh-url, branch-qm option
         script: |
            cd tests/e2e
-           ./set-ffi-env-e2e --branch-qm=main --qm-setup-from-gh-url=https://raw.githubusercontent.com/containers --set-qm-disk-part=yes
+           ./set-ffi-env-e2e --set --set-qm-disk-part=yes
    when: scenario == ffi and distro == centos-stream-9, fedora
 
 execute:

diff --git a/plans/e2e/tier-0.fmf b/plans/e2e/tier-0.fmf
@@ -8,25 +8,32 @@ provision:
    how: local
 
 adjust:
+ - when: scenario == manual
    prepare+:
-      - name: Prepare Repos
-        how: shell
-        script: |
-           dnf install -y dnf-plugin-config-manager epel-release
-           dnf config-manager -y --set-enabled crb
-           dnf -y copr enable rhcontainerbot/qm centos-stream-9
-
-      - name: install repos
-        how: install
-        package:
-           - podman
-
-      - name: Set QM env
-        how: shell
-        script: |
-           cd tests/e2e
-           ./run-test-e2e --skip-tests=yes
-   when: distro == centos-stream-9 or distro == fedora
+     - name: Prepare Repos
+       how: shell
+       order: 10
+       script: |
+          dnf copr enable -y rhcontainerbot/qm
+
+ - when: distro == centos-stream-9 or distro == fedora
+   prepare+:
+     - name: Prepare Repos
+       how: shell
+       script: |
+          dnf install -y dnf-plugin-config-manager epel-release
+          dnf config-manager -y --set-enabled crb
+
+     - name: install repos
+       how: install
+       package:
+          - podman
+
+     - name: Set QM env
+       how: shell
+       script: |
+          cd tests/e2e
+          ./run-test-e2e --skip-tests=yes
 
 execute:
     how: tmt

diff --git a/tests/e2e/lib/ContainerFile.template b/tests/e2e/lib/ContainerFile.template
@@ -5,7 +5,7 @@ RUN dnf install -y \
 	epel-release
 
 RUN dnf config-manager -y --set-enabled crb
-RUN dnf -y copr enable rhcontainerbot/qm centos-stream-9
+RUN dnf -y copr enable centos-stream-9
 RUN dnf config-manager --add-repo https://cli.github.com/packages/rpm/gh-cli.repo
 
 RUN dnf install -y \

diff --git a/tests/e2e/lib/container b/tests/e2e/lib/container
@@ -75,13 +75,15 @@ imageID: ${IMAGE_ID}"
 
 setup_node() {
         local nodeID="${1}"
-
+        local use_qm_copr="${2}"
         # copy control as template to node${number}
         cp ./lib/ContainerFile.template ContainerFile.node"${nodeID}"
         if_error_exit "failed to copy ContainerFile control template to node!"
-
+        if [ -n ${use_qm-copr} ]; then
+           sed 's/copr enable centos-stream-9/& rhcontainerbot\/qm /' -i ContainerFile.node"${nodeID}"
+        fi
         # remove specific code from control mode (template)
-        sed -i '/start/,/end/d' ContainerFile.node"${nodeID}"
+        sed '/start/,/end/d' -i ContainerFile.node"${nodeID}"
         if_error_exit "failed to sed ContainerFile node template!"
 }
 
@@ -97,11 +99,15 @@ create_qm_node() {
 
         setup_node \
             "${nodeID}" \
-            "${IP_CONTROL_MACHINE}"
-
+            "${USE_QM_COPR}"
         # Add final instructions
         echo "RUN dnf install qm -y &> /dev/null" >> ContainerFile.node"${nodeID}"
 
+        if [ -n "${QM_GH_URL}" ]; then
+          curl "${QM_GH_URL}"  > /usr/share/qm/setup
+          chmod +x /usr/share/qm/setup
+        fi
+
         # Execute qm setup
         # Use --skip-systemctl true in podman build, systemd is not running
         # Do not set --skip-systemctl inside running container with systemd in it.

diff --git a/tests/e2e/lib/systemd b/tests/e2e/lib/systemd
@@ -45,8 +45,10 @@ ${container_target}:/tmp/container-${srv}.container"
              eval "${cmd_cp_systemd_srv}"
              if_error_exit "cannot copy container-${srv} to qm container"
 
+             # Find configuration file from service
+             target_service_file=$(podman exec ${container_target} systemctl show -P  SourcePath qm.service)
 	     # START: remove DropCapability to run nested container
-             podman exec -it ${container_target} sed -i '/^\s*DropCapability=sys_resource/ d' /etc/containers/systemd/qm.container
+             podman exec -it ${container_target} bash -c "sed -i '/^\s*DropCapability=sys_resource/ d' \"${target_service_file}\""
 	     if_error_exit "unable to remove DropCapability=sys_resource in qm.container"
 
 	     podman exec -it ${container_target} systemctl daemon-reload

diff --git a/tests/e2e/run-test-e2e b/tests/e2e/run-test-e2e
@@ -38,6 +38,7 @@ export BUILD_QM_FROM_GH_URL=""
 export BUILD_BLUECHI_FROM_GH_URL=""
 export BRANCH_BLUECHI=""
 export BRANCH_QM=""
+export USE_QM_COPR=""
 
 # If no additional nodes are required, use 1
 if [ -z "${NUMBER_OF_NODES}" ]; then
@@ -62,6 +63,7 @@ fi
 ARGUMENT_LIST=(
     "build-qm-from-gh-url"
     "branch-qm"
+    "use-qm-copr"
     "build-bluechi-from-gh-url"
     "branch-bluechi"
     "skip-tests"
@@ -79,7 +81,8 @@ Usage: ./run-test-e2e [OPTIONS]
 	Build QM from a specific GitHub URL, useful for testing new features
 --branch-qm
 	Specify which branch the GitHub repo will be set. Requires --build-qm-from-gh-url
-
+--use-qm-copr
+        Specify to install rpms from rhcontainerbot/qm copr
 --number-of-nodes
 	Specify number of nodes. (default 1)
 
@@ -101,6 +104,7 @@ Examples:
 			--build-qm-from-gh-url=https://github.com/MYUSER/qm.git \\
 			--branch-bluechi=superfeature \\
 			--build-bluechi-from-gh-url=https://github.com/MYUSER/bluechi.git \\
+			--use-qm-copr=Y \\
 
 EOF
     exit 0
@@ -158,6 +162,12 @@ while [ $# -gt 0 ]; do
             shift 2
             ;;
 
+        --use-qm-copr)
+            USE_QM_COPR="${2}"
+            shift 2
+            ;;
+
+
         --help)
             usage
             ;;

diff --git a/tests/e2e/set-ffi-env-e2e b/tests/e2e/set-ffi-env-e2e
@@ -46,6 +46,7 @@ export BUILD_BLUECHI_FROM_GH_URL=""
 export QM_GH_URL=""
 export BRANCH_QM=""
 export SET_QM_PART=""
+export USE_QM_COPR=""
 
 RED='\033[91m'
 GRN='\033[92m'
@@ -56,6 +57,7 @@ ARGUMENT_LIST=(
     "qm-setup-from-gh-url"
     "branch-qm"
     "set-qm-disk-part"
+    "use-qm-copr"
 )
 
 usage() {
@@ -74,16 +76,20 @@ Usage: ./set-ffi-env-e2e [OPTIONS]
 --set-qm-disk-part
         Specify if disk partition neede for /var/qm needed
 
+--use-qm-copr
+        Specify to install rpms from rhcontainerbot/qm copr
+
 Examples:
 
 	No args, it will install latest qm and bluechi from copr rpm repository
 		./set-ffi-env-e2e
 
-        Usee qm setup specific github url and select the branches
+        Use qm setup specific github url and select the branches
                 ./set-ffi-env-e2e \\
                         --branch-qm=superfeature \\
                         --qm-setup-from-gh-url=https://raw.githubusercontent.com/MYUSER/ \\
                         --set-qm-disk-part=Y \\
+                        --use-qm-copr=Y \\
 
 EOF
     exit 0
@@ -119,6 +125,11 @@ while [ $# -gt 0 ]; do
             shift 2
             ;;
 
+        --use-qm-copr)
+            USE_QM_COPR="${2}"
+            shift 2
+            ;;
+
         --help)
             usage
             ;;
@@ -159,7 +170,11 @@ install_qm_rpms() {
   dnf install -y 'dnf-command(config-manager)'
   dnf config-manager --set-enabled crb
   dnf copr enable -y @centos-automotive-sig/bluechi-snapshot centos-stream-9-"${ARCH}"
-  dnf copr enable -y rhcontainerbot/qm centos-stream-9-"${ARCH}"
+  if [ -n "${USE_QM_COPR}" ]; then
+      dnf copr enable -y rhcontainerbot/qm
+  fi
+  dnf copr enable -y centos-stream-9-"${ARCH}"
+
   dnf install -y qm bluechi-ctl bluechi podman hostname
 }