Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: add packages for tmt development #166

Merged
merged 1 commit into from
Aug 12, 2023
Merged

e2e: add packages for tmt development #166

merged 1 commit into from
Aug 12, 2023

Conversation

dougsland
Copy link
Collaborator

Signed-off-by: Douglas Schilling Landgraf [email protected]

Signed-off-by: Douglas Schilling Landgraf <[email protected]>
@dougsland
Copy link
Collaborator Author

all green.

@dougsland dougsland merged commit b4cfb63 into containers:main Aug 12, 2023
6 checks passed
Copy link
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too late to review but anyway. I guess these will end up getting installed on all envs that depend on Containerfile.template ? May not be worth pulling extra deps unless absolutely needed.

@dougsland
Copy link
Collaborator Author

Too late to review but anyway. I guess these will end up getting installed on all envs that depend on
Containerfile.template ? May not be worth pulling extra deps unless absolutely needed.

Never too late, there is git revert ;-). However, I knew this could bring people complaining, but I believe we should start thinking in a different way for these scripts. This became a test and development platform (and E2E) for hirte and qm. Adding few extra piles/Mbs of software to speedup things won't hurt or change our tests results.

A simple example of usage outside of E2E in github actions:
eclipse-bluechi/bluechi#434

Please let me know your thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants