check_run_systemd_journal_socket: add fail case for socket #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If host do not have the socket, let's fail right away Signed-off-by: Douglas Landgraf <[email protected]>
dougsland
requested review from
rhatdan,
lsm5,
Yarboa,
sandrobonazzola,
nsednev,
aesteve-rh and
pengshanyu
as code owners
|
@dougsland Thank you for enhancing it, which I was missing. |
@pengshanyu nobody missed nothing here. teamwork++. If one of us miss something, we all do. There are always space for more improvements. ;-) |
|
@pengshanyu agreed, I am merging. We have one cgroups issue in CI/CD that we are investigating, it's taking longer the report for the final job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If host do not have the socket, let's fail right away